refactor(rsc): remove server optimizeDeps.include in favor of cjs module runner transform
#692
+25
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 238e832.
hi-ogawa
changed the title
optimizeDeps.include in favor of cjs module runner transform
This was referenced Aug 11, 2025
…into 08-11-refactor_rsc_remove_server_optimizedeps.include
|
We should try ecosystem ci (Waku and react-router). If it's fine, we should go forward. |
|
One concern is we might want this with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After #687, this should work in principle. If not, we should improve cjs module runner transform.
TODO
defaultimport interop fix(rsc): fix cjs default import on module runner #695test-provider-in-server-depinpackages/plugin-rsc/examples/basic/src/routes/deps/client-in-server/server.tsxis broken. it looks like dual module of@vitejs/test-dep-client-in-server2/client.?v=won't be added to anymore, which breaksclient-in-server-package-proxydetection logic.isInNodeModuleinstead of?v=fix(rsc): replace?v=check with more robustnode_modulesdetection #696